Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: remove breaking change tags #11324

Merged
merged 1 commit into from
Aug 2, 2023
Merged

docs: remove breaking change tags #11324

merged 1 commit into from
Aug 2, 2023

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Aug 1, 2023

Motivation/summary

With elastic/stack-docs#2495 merged, we no longer need tags to reuse breaking changes in the Stack Install/Upgrade guide.

Checklist

  • Documentation has been updated

Related issues

https://github.com/elastic/platform-docs-team/issues/143

@mergify
Copy link
Contributor

mergify bot commented Aug 1, 2023

This pull request does not have a backport label. Could you fix it @jrodewig? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.x is the label to automatically backport to the 7.x branch.
  • backport-7./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Aug 1, 2023
@jrodewig
Copy link
Contributor Author

jrodewig commented Aug 1, 2023

@bmorelli25 Can you assist with appropriate labels to backport this to 8.9?

It looks like I don't have permissions to add labels myself.

@jrodewig jrodewig marked this pull request as ready for review August 1, 2023 19:07
@jrodewig jrodewig requested a review from a team as a code owner August 1, 2023 19:07
@bmorelli25 bmorelli25 added backport-8.9 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Aug 1, 2023
bmorelli25
bmorelli25 approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmorelli25
Copy link
Member

@elastic/apm-server if this looks good can you please merge when you review? Thanks!

@axw axw merged commit 87ef427 into elastic:main Aug 2, 2023
3 checks passed
mergify bot pushed a commit that referenced this pull request Aug 2, 2023
@jrodewig @mergify
[DOCS] Remove breaking change tags (#11324)
8c59cf9 
(cherry picked from commit 87ef427)
@mergify mergify bot mentioned this pull request Aug 2, 2023
Merged
mergify bot added a commit that referenced this pull request Aug 2, 2023
@mergify @jrodewig
[DOCS] Remove breaking change tags (#11324) (#11325)
7a9fb9f 
(cherry picked from commit 87ef427)

Co-authored-by: James Rodewig <james.rodewig@elastic.co>
bmorelli25 pushed a commit to bmorelli25/apm-server that referenced this pull request Sep 5, 2023
@jrodewig @bmorelli25
[DOCS] Remove breaking change tags (elastic#11324)
a35d00a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axw axw axw approved these changes

@bmorelli25 bmorelli25 bmorelli25 approved these changes

Assignees
No one assigned
Labels
backport-8.9 Automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrodewig @bmorelli25 @axw